Regular code-reviews are supposed to catch errors, bad style, or bad architectural decisions early on in the process. For it to work, however, everyone should be super disciplined and spend a lot of brain-power reading through each diff. Usually, it's really hard to dig into someone's code until you're fully int the cotext (read: working on the same piece of code). On the other hand, I often find myself in the situation when I'm dealing with someone else's code and think, "Oh god, how could I even approve this PR?". The next thing I usually want to do is let the team, and specifically, the code author, know that this is how we should NOT DO things. The problem, however, is that the code-review window has closed and there's no other standard place (besides GitHub PRs) to comment on the code.
I'm wondering if commenting on the code AFTER it has been merged is standard practice on some project and if there are any good tools for that.
Comments URL: https://news.ycombinator.com/item?id=20849504
Points: 4
# Comments: 2
from Hacker News: Newest https://ift.tt/32hDcAh
via IFTTT
No comments:
Post a Comment